Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: icons-new-january-february #5342

Merged
merged 6 commits into from
Feb 19, 2020
Merged

feat: icons-new-january-february #5342

merged 6 commits into from
Feb 19, 2020

Conversation

conradennis
Copy link
Contributor

Submitting new and updated UI icons from January + February
all updates and additions approved by BXD

36 net new icons
1 removed icon (approved by Brand + Legal team, see Carbon issue: #5153)

updated categories.yml with additions and updates
updated ui-icon-master.ai with additions and updates

Changelog

New

  • 32/watson-health/download-study.svg
  • 32/watson-health/hole-filling.svg
  • 32/watson-health/hole-filling--cursor.svg
  • 32/watson-health/smoothing.svg
  • 32/watson-health/smoothing--cursor.svg
  • 32/center--circle.svg
  • 32/center--square.svg
  • 32/circle--filled.svg
  • 32/covariate.svg
  • 32/data-refinery.svg
  • 32/data-table.svg
  • 32/document--download.svg
  • 32/document--pdf.svg
  • 32/document--view.svg
  • 32/double-integer.svg
  • 32/email--new.svg
  • 32/factor.svg
  • 32/fetch-upload.svg
  • 32/fetch-upload--cloud.svg
  • 32/generate-pdf.svg
  • 32/graphical-data-flow.svg
  • 32/hashtag.svg
  • 32/in-progress.svg
  • 32/logo--jupyter.svg
  • 32/logo--python.svg
  • 32/logo--r-script.svg
  • 32/model-builder.svg
  • 32/operations--field.svg
  • 32/operations--record.svg
  • 32/save--model.svg
  • 32/script.svg
  • 32/string-integer.svg
  • 32/string-text.svg
  • 32/sys-provision.svg
  • 32/task--view.svg
  • 32/user--speaker.svg

Removed

  • 32/logo--google.svg

@conradennis
feat: icons-new-january-february
bcb02d8 
Submitting new and updated UI icons from January + February
all updates and additions approved by BXD
@conradennis conradennis requested review from laurenmrice and a team as code owners February 13, 2020 18:37
@ghost ghost requested review from asudoh and dakahn February 13, 2020 18:37
This was referenced Feb 13, 2020
Closed
Closed
@netlify
Copy link

netlify bot commented Feb 13, 2020 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit f15153a

https://deploy-preview-5342--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Feb 13, 2020 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit f15153a

https://deploy-preview-5342--carbon-elements.netlify.com

joshblack
joshblack approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, will make sure to help scaffold out metadata either tomorrow or early next week!

laurenmrice
laurenmrice requested changes Feb 14, 2020
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For 32/circle--filled.svg, this needs to be a completely filled in circle to be able to be used in the progress indicator component for the current state. We need to omit the space between the border and the fill.

Ex:
Screen Shot 2020-02-14 at 9 11 44 AM

Everything else looks good to me 👍🏻

@conradennis
Copy link
Contributor Author

conradennis commented Feb 14, 2020 •
edited
Loading

For 32/circle--filled.svg, this needs to be a completely filled in circle to be able to be used in the progress indicator component for the current state. We need to omit the space between the border and the fill.

Ex:
Screen Shot 2020-02-14 at 9 11 44 AM

Everything else looks good to me 👍🏻

Hey @laurenmrice I originally made it as you specified above but then @jeanservaas slacked me a few days later and mentioned her and Mike decided there should be a space between fill and outer stroke.

@laurenmrice
Copy link
Member

Thanks for clarifying Conrad! Just spoke with jeannie, are you using a 3px gap between the border and the fill? They want a 2px gap, so just wanted to confirm that.

@conradennis
Copy link
Contributor Author

Thanks for clarifying Conrad! Just spoke with jeannie, are you using a 3px gap between the border and the fill? They want a 2px gap, so just wanted to confirm that.

ya we originally agreed on 3px, seems like that's too close to radio button so 2px it is. Will update the icon and the PR in a mo

laurenmrice
laurenmrice approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great ! thanks for making that fix ! 🚀

@joshblack
Copy link
Contributor

joshblack commented Feb 17, 2020 •
edited
Loading

Quick update, waiting on metadata updates over in: #5372 Done!

@joshblack joshblack merged commit b82f079 into carbon-design-system:master Feb 19, 2020
This was referenced Feb 25, 2020
Closed
Closed
@half5cat half5cat mentioned this pull request Jun 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@dakahn dakahn dakahn approved these changes

@laurenmrice laurenmrice laurenmrice approved these changes

@asudoh asudoh Awaiting requested review from asudoh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@conradennis @laurenmrice @joshblack @dakahn @tw15egan